updated indexes to include high contrast support information #1607
Conversation
Regression test coverage:Examples without any regression tests:
Examples missing some regression tests:
Example pages with Keyboard or Attribute table rows that do not have data-test-ids:
SUMMARY:55 example pages found. ERROR - missing tests: Please write missing tests for this report to pass. |
|
@jongund, thank you, adding this to agenda. One concern is that The meaning of(HC) is not clear to readers of the reference tables who don't see the title attribute. Is there room for a column titled "Supports High Contrast"? Wonder what ideas/thoughts others have on that. |
|
@mcking65 |
|
@mcking65 |
|
@mcking65 |
| @@ -55,17 +56,17 @@ <h2 id="examples_by_role_label">Examples by Role</h2> | |||
| <td><code>button</code></td> | |||
| <td> | |||
| <ul> | |||
| <li><a href="button/button_idl.html">Button (IDL Version)</a></li> | |||
| <li><a href="button/button.html">Button</a></li> | |||
| <li><a href="button/button_idl.html" title>Button (IDL Version)</a></li> | |||
There was a problem hiding this comment.
We probably shouldn't append the title attribute if there is no title string
| return ` | ||
| <li><a href="${item.ref}">${item.title}</a></li>`; | ||
| <li><a href="${item.ref}" title="${title}">${item.title}</a>${highContrast}</li>`; |
There was a problem hiding this comment.
The empty title issue could be fixed if the title=" string were part of the variable, e.g.:
let title='';
(...)
title='title="High Contrast Support"`;
(...)
<a href="etc"${title}>
Though I still think the link tooltip is better left off entirely :D
| </ul> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td><code>checkbox</code></td> | ||
| <td> | ||
| <ul> | ||
| <li><a href="checkbox/checkbox-1/checkbox-1.html">Checkbox (Two State)</a></li> | ||
| <li><a href="checkbox/checkbox-2/checkbox-2.html">Checkbox (Mixed-State)</a></li> | ||
| <li><a href="checkbox/checkbox-1/checkbox-1.html" title="High Contrast Support">Checkbox (Two State)</a> (<abbr title="High Contrast Support">HC</abbr>)</li> |
There was a problem hiding this comment.
I'm not a big fan of having a tooltip that says "High Contrast Support" on the link. It's a rather weird experience for a sighted user, tooltips have a bunch of known accessibility and usability issues, and we already have one on the abbreviation.
If we want a programmatic association on the link itself for screen reader users, we could use aria-describedby pointing at a single node.
|
Per conversation in March 30 meeting:
|
Updates the reference tables and coverage report to include information about high contrast support.
Many examples with high contrast support do not document the support.
In the reference table and the coverage report, examples with high contrast support have "(HC)" after the example title and a title attribute is added to the example link with the content "High Contrast Support".
In the coverage report there are two additional lists, one with examples with high contrast support and the other of examples without high contrast support.
Preview link to reference table.
Preview link to coverage report.